Re: [PATCH 2/2] Handle emulation failure in userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 1, 2009 at 2:31 PM, Marcelo Tosatti<mtosatti@xxxxxxxxxx> wrote:
> On Fri, Aug 28, 2009 at 04:48:53PM +0200, Mohammed Gamal wrote:
>> Since we return to userspace from KVM on invalid state emulation failure, let
>> qemu handle it.
>>
>> Signed-off-by: Mohammed Gamal <m.gamal005@xxxxxxxxx>
>> ---
>>  qemu-kvm.c |    8 ++++++++
>>  1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-kvm.c b/qemu-kvm.c
>> index b59e403..a1648e0 100644
>> --- a/qemu-kvm.c
>> +++ b/qemu-kvm.c
>> @@ -1029,6 +1029,14 @@ int kvm_run(kvm_vcpu_context_t vcpu, void *env)
>>              r = kvm_s390_handle_reset(kvm, vcpu, run);
>>              break;
>>  #endif
>> +     case KVM_EXIT_INTERNAL_ERROR:
>> +         kvm_show_regs(vcpu);
>> +         fprintf(stderr, "\nKVM internal error. Suberror: %d\n",
>> +                 run->internal.suberror);
>> +         if (run->internal.suberror == KVM_INTERNAL_ERROR_EMULATION)
>> +             fprintf(stderr, "emulation failure, check dmesg for details\n");
>> +         abort();
>> +         break;
>>          default:
>>              if (kvm_arch_run(vcpu)) {
>>                  fprintf(stderr, "unhandled vm exit: 0x%x\n", run->exit_reason);
>> --
>> 1.6.0.4
>
> The common practice is to print msg first and then kvm_show_regs?
True. I just thought the message would be more visible this way. Will resend

> Applied the kvm.h update, thanks.
>
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux