Avi Kivity wrote: > On 09/01/2009 02:45 PM, Jan Kiszka wrote: >> Avi Kivity wrote: >> >>> On 09/01/2009 02:33 PM, Jan Kiszka wrote: >>> >>>> For the time being, falling back to conservative save/restore if kgdb is >>>> configured in and kgdb_connected != 0 should allow us to apply this >>>> optimization otherwise. >>>> >>>> >>> I prefer a real fix instead of spaghettiing the code this way (and in >>> the meanwhile I'm fine with kgdb hardware breakpoints not working while >>> kvm is running). >>> >> Then file a patch that makes CONFIG_KVM depend on !CONFIG_KGDB (or vice >> versa). Silent breakages are evil. >> > > Distros typically enable both. Then we need to resolve it right from the start, not in some distant future. We already have everything we need available, we could just try to refactor it to a nicer interface (something that encapsulates both compile and runtime tests). Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
