On Tue, Jul 21, 2020 at 9:29 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Jul 21, 2020 at 09:02:15AM -0700, Dave Jiang wrote: > > v2: > > "RFC" to me means "I don't really think this is mergable, so I'm > throwing it out there." Which implies you know it needs more work > before others should review it as you are not comfortable with it :( There's full blown reviewed-by from me on the irq changes. The VFIO / mdev changes looked ok to me, but I did not feel comfortable / did not have time to sign-off on them. At the same time I did not see much to be gained to keeping those internal. So "RFC" in this case is a bit modest. It's more internal reviewer said this looks like it is going in the right direction, but wants more community discussion on the approach. > So, back-of-the-queue you go... Let's consider this not RFC in that context. The drivers/base/ pieces have my review for you, the rest are dmaengine and vfio subsystem concerns that could use some commentary.