Re: [PATCH 5/7] virtio_vdpa: init IRQ offloading function pointers to NULL.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2020/7/13 下午6:20, Zhu, Lingshan wrote:


On 7/13/2020 4:28 PM, Jason Wang wrote:

On 2020/7/12 下午10:49, Zhu Lingshan wrote:
This commit initialize IRQ offloading function pointers in
virtio_vdpa_driver to NULL. Becasue irq offloading only focus
on VMs for vhost_vdpa.

Signed-off-by: Zhu Lingshan <lingshan.zhu@xxxxxxxxx>
---
  drivers/virtio/virtio_vdpa.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
index c30eb55..1e8acb9 100644
--- a/drivers/virtio/virtio_vdpa.c
+++ b/drivers/virtio/virtio_vdpa.c
@@ -386,6 +386,8 @@ static void virtio_vdpa_remove(struct vdpa_device *vdpa)
      },
      .probe    = virtio_vdpa_probe,
      .remove = virtio_vdpa_remove,
+    .setup_vq_irq = NULL,
+    .unsetup_vq_irq = NULL,
  };


Is this really needed consider the it's static?

Thanks
This is for readability, to show they are NULL, so virtio_vdpa would not go through irq forwarding / offloading.

Does this make sense?


Probably not, please refer what is done by other subsystems.

Thanks



Thanks,
BR
Zhu Lingshan


module_vdpa_driver(virtio_vdpa_driver);





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux