On Tue, Jul 14, 2020 at 01:26:24PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson <sean.j.christopherson@xxxxxxxxx> writes: > > IMO the addition of nested_npt_enabled() should be a separate patch, and > > the additoin of @nested_npt should be in patch 7. > > > > Hypothetically speaking, if nested_npt_enabled() is inaccurate at the call > > site in nested_prepare_vmcb_save(), then this patch is technically wrong > > even though it doesn't introduce a bug. Given that the call site of > > nested_svm_load_cr3() is moved in patch 7, I don't see any value in adding > > the placeholder parameter early. > > > > I see and I mostly agree, I put it here to avoid the unneeded churn and > make it easier to review the whole thing: this patch is technically a > nop so it can be reviewed in "doesn't change anything" mode and patches > which actually change things are smaller. > > Paolo already said 'queued' here and your comments can't be addressed in > a follow-up patch but I can certainly do v5 if needed. Eh, not necessary, I didn't see that the series was in kvm/queue until after I hit send. Thanks!
