> On Jul 13, 2020, at 8:23 AM, Thomas Huth <thuth@xxxxxxxxxx> wrote: > > On 11/07/2020 18.14, Nadav Amit wrote: >> FW_CFG_MAX_ENTRY should obviously be the last entry. >> >> Signed-off-by: Nadav Amit <namit@xxxxxxxxxx> >> --- >> lib/x86/fwcfg.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/x86/fwcfg.h b/lib/x86/fwcfg.h >> index 64d4c6e..8095d8a 100644 >> --- a/lib/x86/fwcfg.h >> +++ b/lib/x86/fwcfg.h >> @@ -20,8 +20,8 @@ >> #define FW_CFG_NUMA 0x0d >> #define FW_CFG_BOOT_MENU 0x0e >> #define FW_CFG_MAX_CPUS 0x0f >> -#define FW_CFG_MAX_ENTRY 0x10 >> -#define FW_CFG_MAX_RAM 0x11 >> +#define FW_CFG_MAX_RAM 0x10 >> +#define FW_CFG_MAX_ENTRY 0x11 > > That should hopefully also fix the problem with Clang that I've just seen: > > https://gitlab.com/huth/kvm-unit-tests/-/jobs/635782173#L1372 > > Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx> Indeed. Sorry for that. It happened since I cut some corners due to the long cycles of rebooting and testing bare-metal machine (bad excuse).
