On 07/07/20 02:34, Krish Sadhukhan wrote: >> > > Sorry, Paolo, I got bit lost here :-). IIRC, you had two comments on > this set: > > 1. kvm_valid_cr4() should be used for checking the reserved bits in > guest CR4 > > 2. LMA shouldn't be checked via guest state > > v3 has addressd your first suggestion by caching CR4 reserved bits in > kvm_update_cpuid() and then using kvm_valid_cr4() in nested_vmcb_checks(). > > As for your second suggestion, v3 uses is_long_mode() which uses > vcpu->arch.efer for checking long mode. > > I will send out a rebased version. > > Is there anything I missed ? Maybe Sean's comment here: https://patchwork.kernel.org/patch/11550707/ Paolo
