On 24/06/20 22:36, Nadav Amit wrote:
> smp_stacktop in 32-bit is fixed to some magic address. Use the address
> of the memory that was reserved for the stack instead.
>
> Signed-off-by: Nadav Amit <namit@xxxxxxxxxx>
> ---
> x86/cstart.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/cstart.S b/x86/cstart.S
> index 1d8b8ac..a072aed 100644
> --- a/x86/cstart.S
> +++ b/x86/cstart.S
> @@ -134,7 +134,7 @@ prepare_32:
> mov %eax, %cr0
> ret
>
> -smp_stacktop: .long 0xa0000
> +smp_stacktop: .long stacktop - 4096
>
> save_id:
> movl $(APIC_DEFAULT_PHYS_BASE + APIC_ID), %eax
>
This uncovers a latent bug for which I've just sent a patch ("x86: fix
stack pointer after call").
Paolo
