Re: [PATCH][RFC] Use return value from kvm_set_irq() to re-inject PIT interrupts.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/26/2009 04:38 PM, Marcelo Tosatti wrote:

An injectable timer interrupt is defined by:

- time(now)>= time(next_expiration)
- Previous timer interrupt has been acked (thus we can inject).

The thing is, sure you can drop ack notifiers and check IRR
on every guest entry, but why bother if you can receive an
asynchronous notification?

Would you prefer to replace

+               if (!ktimer->can_inject)

With
		kvm_set_irq()

?

Not relatively cheap.

Well, we expect it to be a rare condition that we have pending timer interrupts, so if it leads to significant code simplification, it can be worthwhile.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux