On Mon, Aug 24, 2009 at 10:01:50PM +0300, Gleb Natapov wrote: > On Mon, Aug 24, 2009 at 09:19:05PM +0300, Gleb Natapov wrote: > > > > It is obviously wrong thing to do from assigned devices POV. > > > > > > Thats not entirely clear to me. So what happens if a guest with PIC > > > assigned device resets with a pending IRR? The host interrupt line will > > > be kept disabled, even though the guest is able to process further > > > interrupts? > > The host interrupt line will be enabled (assigned device ack notifier > > does this) without clearing interrupt condition in assigned device > > (guest hasn't acked irq so how can we be sure it ran device's irq > > handler?). Host will hang. > > > Actually, on the second thought, it will not hang. Next time host > interrupt handler runs it will disable interrupt once again. Right. And if you don't signal ack notification on reset with pending IRR the host line will be kept disabled. As said on other email, its not specific to PIT reinjection logic. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html