On 2020-06-17 10:48, Cornelia Huck wrote:
On Mon, 15 Jun 2020 11:31:59 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:
First step for testing the channel subsystem is to enumerate the css and
retrieve the css devices.
Maybe worth adding a note:
"We currently don't enable multiple subchannel sets and therefore only
look in subchannel set 0."
right, thanks
This tests the success of STSCH I/O instruction, we do not test the
reaction of the VM for an instruction with wrong parameters.
...snip...
+ for (scn = 0; scn < 0xffff; scn++) {
+ cc = stsch(scn | SCHID_ONE, &schib);
+ switch (cc) {
+ case 0: /* 0 means SCHIB stored */
+ break;
+ case 3: /* 3 means no more channels */
+ goto out;
+ default: /* 1 or 2 should never happened for STSCH */
s/happened/happen/
yes
...snip...
diff --git a/s390x/css.c b/s390x/css.c
...
+static void test_enumerate(void)
+{
+ test_device_sid = css_enumerate();
+ if (test_device_sid & SCHID_ONE) {
+ report(1, "First device schid: 0x%08x", test_device_sid);
Maybe "Schid of first I/O device" ?
yes, better.
...snip...
+}
Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
Thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
