Paolo Bonzini <pbonzini@xxxxxxxxxx> writes: > is_intercept takes an INTERCEPT_* constant, not SVM_EXIT_*; because > of this, the compiler was removing the body of the conditionals, > as if is_intercept returned 0. > > This unveils a latent bug: when clearing the VINTR intercept, > int_ctl must also be changed in the L1 VMCB (svm->nested.hsave), > just like the intercept itself is also changed in the L1 VMCB. > Otherwise V_IRQ remains set and, due to the VINTR intercept being clear, > we get a spurious injection of a vector 0 interrupt on the next > L2->L1 vmexit. > > Reported-by: Qian Cai <cai@xxxxxx> > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > --- > Vitaly, can you give this a shot with Hyper-V? I have already > placed it on kvm/queue, it passes both svm.flat and KVM-on-KVM > smoke tests. Quickly smoke-tested this with WS2016/2019 BIOS/UEFI and the patch doesn't seem to break anything. I'm having issues trying to launch a Gen2 (UEFI) VM in Hyper-V (Gen1 works OK) but the behavior looks exactly the same pre- and post-patch. -- Vitaly
