Re: [PATCH v8 02/16] s390/vfio-ap: use new AP bus interface to search for queue devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tony,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kvms390/next]
[also build test WARNING on linus/master v5.7]
[cannot apply to s390/features linux/master next-20200605]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20200606-054350
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/s390/crypto/vfio_ap_ops.c:130:24: warning: no previous prototype for 'vfio_ap_irq_disable' [-Wmissing-prototypes]
130 | struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q)
|                        ^~~~~~~~~~~~~~~~~~~
>> drivers/s390/crypto/vfio_ap_ops.c:1110:5: warning: no previous prototype for 'vfio_ap_mdev_reset_queue' [-Wmissing-prototypes]
1110 | int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
|     ^~~~~~~~~~~~~~~~~~~~~~~~

vim +/vfio_ap_irq_disable +130 drivers/s390/crypto/vfio_ap_ops.c

ec89b55e3bce7c Pierre Morel          2019-05-21  113  
ec89b55e3bce7c Pierre Morel          2019-05-21  114  /**
ec89b55e3bce7c Pierre Morel          2019-05-21  115   * vfio_ap_irq_disable
ec89b55e3bce7c Pierre Morel          2019-05-21  116   * @q: The vfio_ap_queue
ec89b55e3bce7c Pierre Morel          2019-05-21  117   *
ec89b55e3bce7c Pierre Morel          2019-05-21  118   * Uses ap_aqic to disable the interruption and in case of success, reset
ec89b55e3bce7c Pierre Morel          2019-05-21  119   * in progress or IRQ disable command already proceeded: calls
ec89b55e3bce7c Pierre Morel          2019-05-21  120   * vfio_ap_wait_for_irqclear() to check for the IRQ bit to be clear
ec89b55e3bce7c Pierre Morel          2019-05-21  121   * and calls vfio_ap_free_aqic_resources() to free the resources associated
ec89b55e3bce7c Pierre Morel          2019-05-21  122   * with the AP interrupt handling.
ec89b55e3bce7c Pierre Morel          2019-05-21  123   *
ec89b55e3bce7c Pierre Morel          2019-05-21  124   * In the case the AP is busy, or a reset is in progress,
ec89b55e3bce7c Pierre Morel          2019-05-21  125   * retries after 20ms, up to 5 times.
ec89b55e3bce7c Pierre Morel          2019-05-21  126   *
ec89b55e3bce7c Pierre Morel          2019-05-21  127   * Returns if ap_aqic function failed with invalid, deconfigured or
ec89b55e3bce7c Pierre Morel          2019-05-21  128   * checkstopped AP.
ec89b55e3bce7c Pierre Morel          2019-05-21  129   */
ec89b55e3bce7c Pierre Morel          2019-05-21 @130  struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q)
ec89b55e3bce7c Pierre Morel          2019-05-21  131  {
ec89b55e3bce7c Pierre Morel          2019-05-21  132  	struct ap_qirq_ctrl aqic_gisa = {};
ec89b55e3bce7c Pierre Morel          2019-05-21  133  	struct ap_queue_status status;
ec89b55e3bce7c Pierre Morel          2019-05-21  134  	int retries = 5;
ec89b55e3bce7c Pierre Morel          2019-05-21  135  
ec89b55e3bce7c Pierre Morel          2019-05-21  136  	do {
ec89b55e3bce7c Pierre Morel          2019-05-21  137  		status = ap_aqic(q->apqn, aqic_gisa, NULL);
ec89b55e3bce7c Pierre Morel          2019-05-21  138  		switch (status.response_code) {
ec89b55e3bce7c Pierre Morel          2019-05-21  139  		case AP_RESPONSE_OTHERWISE_CHANGED:
ec89b55e3bce7c Pierre Morel          2019-05-21  140  		case AP_RESPONSE_NORMAL:
ec89b55e3bce7c Pierre Morel          2019-05-21  141  			vfio_ap_wait_for_irqclear(q->apqn);
ec89b55e3bce7c Pierre Morel          2019-05-21  142  			goto end_free;
ec89b55e3bce7c Pierre Morel          2019-05-21  143  		case AP_RESPONSE_RESET_IN_PROGRESS:
ec89b55e3bce7c Pierre Morel          2019-05-21  144  		case AP_RESPONSE_BUSY:
ec89b55e3bce7c Pierre Morel          2019-05-21  145  			msleep(20);
ec89b55e3bce7c Pierre Morel          2019-05-21  146  			break;
ec89b55e3bce7c Pierre Morel          2019-05-21  147  		case AP_RESPONSE_Q_NOT_AVAIL:
ec89b55e3bce7c Pierre Morel          2019-05-21  148  		case AP_RESPONSE_DECONFIGURED:
ec89b55e3bce7c Pierre Morel          2019-05-21  149  		case AP_RESPONSE_CHECKSTOPPED:
ec89b55e3bce7c Pierre Morel          2019-05-21  150  		case AP_RESPONSE_INVALID_ADDRESS:
ec89b55e3bce7c Pierre Morel          2019-05-21  151  		default:
ec89b55e3bce7c Pierre Morel          2019-05-21  152  			/* All cases in default means AP not operational */
ec89b55e3bce7c Pierre Morel          2019-05-21  153  			WARN_ONCE(1, "%s: ap_aqic status %d\n", __func__,
ec89b55e3bce7c Pierre Morel          2019-05-21  154  				  status.response_code);
ec89b55e3bce7c Pierre Morel          2019-05-21  155  			goto end_free;
ec89b55e3bce7c Pierre Morel          2019-05-21  156  		}
ec89b55e3bce7c Pierre Morel          2019-05-21  157  	} while (retries--);
ec89b55e3bce7c Pierre Morel          2019-05-21  158  
ec89b55e3bce7c Pierre Morel          2019-05-21  159  	WARN_ONCE(1, "%s: ap_aqic status %d\n", __func__,
ec89b55e3bce7c Pierre Morel          2019-05-21  160  		  status.response_code);
ec89b55e3bce7c Pierre Morel          2019-05-21  161  end_free:
ec89b55e3bce7c Pierre Morel          2019-05-21  162  	vfio_ap_free_aqic_resources(q);
5c4c2126fb6981 Christian Borntraeger 2019-07-05  163  	q->matrix_mdev = NULL;
ec89b55e3bce7c Pierre Morel          2019-05-21  164  	return status;
ec89b55e3bce7c Pierre Morel          2019-05-21  165  }
ec89b55e3bce7c Pierre Morel          2019-05-21  166  

:::::: The code at line 130 was first introduced by commit
:::::: ec89b55e3bce7c8a4bc6b1203280e81342d6745c s390: ap: implement PAPQ AQIC interception in kernel

:::::: TO: Pierre Morel <pmorel@xxxxxxxxxxxxx>
:::::: CC: Vasily Gorbik <gor@xxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux