This patch accesses the ACPI system from vfio_pci_probe to print out
info if the PCI device being attached to vfio_pci is an i2c adapter with
associated i2c client devices that use platform IRQs. The info printed
out is the IRQ numbers that are associated with the given i2c client
devices. This patch doesn't attempt to forward any additional IRQs into
the guest, but shows how it could be possible.
Signed-off-by: Micah Morton <mortonm@xxxxxxxxxxxx>
Change-Id: I5c77d35f246781a4a80703820860631e2c2091cf
---
What do you guys think about having code like this somewhere in
vfio_pci? There would have to be some logic added in vfio_pci to forward
these IRQs when they are found. For reference, below is what is printed
out during vfio_pci_probe on my development machine when I attach some
I2C adapter PCI devices to vfio_pci:
[ 48.742699] ACPI i2c client device WCOM50C1:00 uses irq 31
[ 53.913295] ACPI i2c client device GOOG0005:00 uses irq 24
[ 58.040076] ACPI i2c client device ACPI0C50:00 uses irq 51
Ideally we could add code like this for other bus types (e.g. SPI).
NOTE: developed on v5.4
drivers/vfio/pci/vfio_pci.c | 158 ++++++++++++++++++++++++++++++++++++
1 file changed, 158 insertions(+)
diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index 02206162eaa9..9ce3f34aa548 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -28,6 +28,10 @@
#include <linux/vgaarb.h>
#include <linux/nospec.h>
+#include <linux/acpi.h>
+#include <acpi/actypes.h>
+#include <linux/i2c.h>
+
#include "vfio_pci_private.h"
#define DRIVER_VERSION "0.2"
@@ -1289,12 +1293,166 @@ static const struct vfio_device_ops vfio_pci_ops = {
static int vfio_pci_reflck_attach(struct vfio_pci_device *vdev);
static void vfio_pci_reflck_put(struct vfio_pci_reflck *reflck);
+
+struct i2c_acpi_lookup {
+ struct i2c_board_info *info;
+ acpi_handle adapter_handle;
+ acpi_handle device_handle;
+ acpi_handle search_handle;
+ int n;
+ int index;
+ u32 speed;
+ u32 min_speed;
+ u32 force_speed;
+};
+
+static const struct acpi_device_id i2c_acpi_ignored_device_ids[] = {
+ /*
+ * ACPI video acpi_devices, which are handled by the acpi-video driver
+ * sometimes contain a SERIAL_TYPE_I2C ACPI resource, ignore these.
+ */
+ { ACPI_VIDEO_HID, 0 },
+ {}
+};
+
+static int i2c_acpi_get_info_for_node(struct acpi_resource *ares, void *data)
+{
+ struct i2c_acpi_lookup *lookup = data;
+ struct i2c_board_info *info = lookup->info;
+ struct acpi_resource_i2c_serialbus *sb;
+ acpi_status status;
+
+ if (info->addr || !i2c_acpi_get_i2c_resource(ares, &sb))
+ return 1;
+
+ if (lookup->index != -1 && lookup->n++ != lookup->index)
+ return 1;
+
+ status = acpi_get_handle(lookup->device_handle,
+ sb->resource_source.string_ptr,
+ &lookup->adapter_handle);
+ if (ACPI_FAILURE(status))
+ return 1;
+
+ info->addr = sb->slave_address;
+
+ return 1;
+}
+
+static int print_irq_info_if_i2c_slave(struct acpi_device *adev,
+ struct i2c_acpi_lookup *lookup, acpi_handle adapter)
+{
+ struct i2c_board_info *info = lookup->info;
+ struct list_head resource_list, resource_list2;
+ struct resource_entry *entry;
+ int ret;
+
+ if (acpi_bus_get_status(adev) || !adev->status.present)
+ return -EINVAL;
+
+ if (acpi_match_device_ids(adev, i2c_acpi_ignored_device_ids) == 0)
+ return -ENODEV;
+
+ memset(info, 0, sizeof(*info));
+ lookup->device_handle = acpi_device_handle(adev);
+
+ /* Look up for I2cSerialBus resource */
+ INIT_LIST_HEAD(&resource_list);
+ ret = acpi_dev_get_resources(adev, &resource_list,
+ i2c_acpi_get_info_for_node, lookup);
+
+
+ if (ret < 0 || !info->addr) {
+ acpi_dev_free_resource_list(&resource_list);
+ return -EINVAL;
+ }
+
+ if (adapter) {
+ /* The adapter must match the one in I2cSerialBus() connector */
+ if (adapter != lookup->adapter_handle)
+ return -ENODEV;
+ }
+
+ INIT_LIST_HEAD(&resource_list2);
+ ret = acpi_dev_get_resources(adev, &resource_list2, NULL, NULL);
+ if (ret < 0)
+ return -EINVAL;
+
+ resource_list_for_each_entry(entry, &resource_list2) {
+ if (resource_type(entry->res) == IORESOURCE_IRQ) {
+ printk(KERN_EMERG "ACPI i2c client device %s uses irq %d\n",
+ dev_name(&adev->dev), entry->res->start);
+ break;
+ }
+ }
+
+ acpi_dev_free_resource_list(&resource_list2);
+
+ return 0;
+}
+
+static int i2c_acpi_get_info(struct acpi_device *adev,
+ struct i2c_board_info *info,
+ acpi_handle adapter,
+ acpi_handle *adapter_handle)
+{
+ struct i2c_acpi_lookup lookup;
+
+
+ memset(&lookup, 0, sizeof(lookup));
+ lookup.info = info;
+ lookup.index = -1;
+
+ if (acpi_device_enumerated(adev))
+ return -EINVAL;
+
+ return print_irq_info_if_i2c_slave(adev, &lookup, adapter);
+}
+
+static acpi_status process_acpi_node(acpi_handle handle, u32 level,
+ void *data, void **return_value)
+{
+ acpi_handle adapter = data;
+ struct acpi_device *adev;
+ struct i2c_board_info info;
+
+ if (acpi_bus_get_device(handle, &adev))
+ return AE_OK;
+
+ if (i2c_acpi_get_info(adev, &info, adapter, NULL))
+ return AE_OK;
+
+ return AE_OK;
+}
+
+#define MAX_SCAN_DEPTH 32
+
+void acpi_print_irqs_if_i2c(acpi_handle handle)
+{
+ acpi_status status;
+
+ status = acpi_walk_namespace(ACPI_TYPE_DEVICE, handle,
+ MAX_SCAN_DEPTH,
+ process_acpi_node, NULL,
+ handle, NULL);
+ if (ACPI_FAILURE(status))
+ printk(KERN_EMERG "failed to enumerate ACPI devices\n");
+}
+
+static void print_irqs_if_i2c_adapter(struct device *dev) {
+ acpi_handle handle = ACPI_HANDLE(dev);
+ acpi_print_irqs_if_i2c(handle);
+}
+
static int vfio_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
{
struct vfio_pci_device *vdev;
struct iommu_group *group;
int ret;
+ if (has_acpi_companion(&pdev->dev))
+ print_irqs_if_i2c_adapter(&pdev->dev);
+
if (pdev->hdr_type != PCI_HEADER_TYPE_NORMAL)
return -EINVAL;
--
2.26.2
