On 5/20/20 8:43 PM, David Gibson wrote: > The kvm_memcrypt_enabled() and kvm_memcrypt_encrypt_data() helper functions > don't conceptually have any connection to KVM (although it's not possible > in practice to use them without it). Yet? I would expect TCG implementations of these interfaces eventually, for simulation of such hardware. Or are we expecting *this* interface to be used only with kvm/any-other-hw-accel, as the nested guest inside of the outermost tcg qemu that's simulating hardware that supports... Anyway, the actual code looks ok. Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx> r~