Re: [RFC v2 12/18] guest memory protection: Perform KVM init via interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC v2 12/18] guest memory protection: Perform KVM init via interface
From: Richard Henderson <richard.henderson@xxxxxxxxxx>
Date: Mon, 1 Jun 2020 20:39:11 -0700
Cc: Eduardo Habkost <ehabkost@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, cohuck@xxxxxxxxxx, mdroth@xxxxxxxxxxxxxxxxxx, qemu-ppc@xxxxxxxxxx, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>
In-reply-to: <20200521034304.340040-13-david@gibson.dropbear.id.au>
References: <20200521034304.340040-1-david@gibson.dropbear.id.au> <20200521034304.340040-13-david@gibson.dropbear.id.au>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 5/20/20 8:42 PM, David Gibson wrote:
> +        if (object_dynamic_cast(obj, TYPE_GUEST_MEMORY_PROTECTION)) {
> +            GuestMemoryProtection *gmpo = GUEST_MEMORY_PROTECTION(obj);

This duplicates the interface check.  You should use

  gmpo = (GuestMemoryProtection *)
    object_dynamic_cast(obj, TYPE_GUEST_MEMORY_PROTECTION);
  if (gmpo) {

AFICT.


r~

Follow-Ups:
- Re: [RFC v2 12/18] guest memory protection: Perform KVM init via interface
  - From: Richard Henderson

References:
- [RFC v2 00/18] Refactor configuration of guest memory protection
  - From: David Gibson
- [RFC v2 12/18] guest memory protection: Perform KVM init via interface
  - From: David Gibson

Prev by Date: Re: [RFC v2 11/18] guest memory protection: Handle memory encrption via interface
Next by Date: Re: [RFC v2 13/18] guest memory protection: Move side effect out of machine_set_memory_encryption()
Previous by thread: [RFC v2 12/18] guest memory protection: Perform KVM init via interface
Next by thread: Re: [RFC v2 12/18] guest memory protection: Perform KVM init via interface
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]