On Mon, Jun 01, 2020 at 12:47:12PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2020-05-26 at 08:51 +0200, Greg KH wrote: > > > > And get them to sign off on it too, showing they agree with the design > > decisions here :) > > Isn't it generally frowned upon to publish a patch with internal sign- > off's on it already ? Not at all. > Or do you mean for us to publicly sign off once we have reviewed ? Either is fine, as long as you do the public one "quickly" and don't rely on others to do the review first :) thanks, greg k-h