On 28/05/20 17:40, Xiaoyao Li wrote: >> >>> kvm_x86_ops.cpuid_update() is used to update vmx/svm settings based on >>> updated CPUID settings. So it's supposed to be called after CPUIDs are >>> fully updated, not in the middle stage. >>> >>> Signed-off-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx> >> >> Are you seeing anything bad happening from this? > > Not yet. > > IMO changing the order is more reasonable and less confusing. Indeed, I just could not decide whether to include it in 5.7 or not. Paolo