Hi Sudeep, > -----Original Message----- > From: Sudeep Holla <sudeep.holla@xxxxxxx> > Sent: Tuesday, May 26, 2020 6:10 PM > To: Jianyong Wu <Jianyong.Wu@xxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx; yangbo.lu@xxxxxxx; john.stultz@xxxxxxxxxx; > tglx@xxxxxxxxxxxxx; pbonzini@xxxxxxxxxx; sean.j.christopherson@xxxxxxxxx; > maz@xxxxxxxxxx; richardcochran@xxxxxxxxx; Mark Rutland > <Mark.Rutland@xxxxxxx>; will@xxxxxxxxxx; Suzuki Poulose > <Suzuki.Poulose@xxxxxxx>; Steven Price <Steven.Price@xxxxxxx>; Justin > He <Justin.He@xxxxxxx>; Wei Chen <Wei.Chen@xxxxxxx>; > kvm@xxxxxxxxxxxxxxx; Steve Capper <Steve.Capper@xxxxxxx>; linux- > kernel@xxxxxxxxxxxxxxx; Kaly Xin <Kaly.Xin@xxxxxxx>; nd <nd@xxxxxxx>; > Sudeep Holla <Sudeep.Holla@xxxxxxx>; kvmarm@xxxxxxxxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [RFC PATCH v12 03/11] psci: export smccc conduit get helper. > > On Mon, May 25, 2020 at 01:37:56AM +0000, Jianyong Wu wrote: > > Hi Sudeep, > > > > > -----Original Message----- > > > From: Sudeep Holla <sudeep.holla@xxxxxxx> > > > Sent: Friday, May 22, 2020 9:12 PM > > > To: Jianyong Wu <Jianyong.Wu@xxxxxxx> > > > Cc: netdev@xxxxxxxxxxxxxxx; yangbo.lu@xxxxxxx; > > > john.stultz@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; pbonzini@xxxxxxxxxx; > > > sean.j.christopherson@xxxxxxxxx; maz@xxxxxxxxxx; > > > richardcochran@xxxxxxxxx; Mark Rutland <Mark.Rutland@xxxxxxx>; > > > will@xxxxxxxxxx; Suzuki Poulose <Suzuki.Poulose@xxxxxxx>; Steven > > > Price <Steven.Price@xxxxxxx>; Justin He <Justin.He@xxxxxxx>; Wei > > > Chen <Wei.Chen@xxxxxxx>; kvm@xxxxxxxxxxxxxxx; Steve Capper > > > <Steve.Capper@xxxxxxx>; linux- kernel@xxxxxxxxxxxxxxx; Kaly Xin > > > <Kaly.Xin@xxxxxxx>; nd <nd@xxxxxxx>; Sudeep Holla > > > <Sudeep.Holla@xxxxxxx>; kvmarm@xxxxxxxxxxxxxxxxxxxxx; > > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > > Subject: Re: [RFC PATCH v12 03/11] psci: export smccc conduit get helper. > > > > > > On Fri, May 22, 2020 at 04:37:16PM +0800, Jianyong Wu wrote: > > > > Export arm_smccc_1_1_get_conduit then modules can use smccc > helper > > > > which adopts it. > > > > > > > > Acked-by: Mark Rutland <mark.rutland@xxxxxxx> > > > > Signed-off-by: Jianyong Wu <jianyong.wu@xxxxxxx> > > > > --- > > > > drivers/firmware/psci/psci.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/firmware/psci/psci.c > > > > b/drivers/firmware/psci/psci.c index 2937d44b5df4..fd3c88f21b6a > > > > 100644 > > > > --- a/drivers/firmware/psci/psci.c > > > > +++ b/drivers/firmware/psci/psci.c > > > > @@ -64,6 +64,7 @@ enum arm_smccc_conduit > > > > arm_smccc_1_1_get_conduit(void) > > > > > > > > return psci_ops.conduit; > > > > } > > > > +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit); > > > > > > > > > > I have moved this into drivers/firmware/smccc/smccc.c [1] Please > > > update this accordingly. > > > > Ok, I will remove this patch next version. > > You may need it still, just that this patch won't apply as the function is moved > to a new file. > Yeah, Thanks for remainder! Thanks Jianyong > -- > Regards, > Sudeep