On Tue, May 26, 2020 at 01:13:19AM +0300, Andra Paraschiv wrote: > +/* Nitro Enclaves (NE) misc device */ > +extern struct miscdevice ne_miscdevice; Why does your misc device need to be in a .h file? Having the patch series like this (add random .h files, and then start to use them), is hard to review. Would you want to try to review a series written in this way? thanks, greg k-h