On 21/05/20 11:27, Vitaly Kuznetsov wrote: > 彭浩(Richard) <richard.peng@xxxxxxxx> writes: > >> pic_in_kernel(),ioapic_in_kernel() and irqchip_kernel() have the >> same implementation. > 'pic_in_kernel()' name is misleading, one may think this is about lapic > and it's not. Also, ioapic_in_kernel() doesn't have that many users, can > we maybe converge on using irqchip_*() functions everywhere? > Richard's patch was my recommendation actually. PIC is not the LAPIC and not the IOAPIC; even though right now the implementation is the same for pic_in_kernel and ioapic_in_kernel and irqchip_kernel(), that's more or less an implementation detail. Paolo
