Re: [PATCH 0/2 v3] Fix VMX preemption timer migration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 20, 2020 at 04:22:26PM -0700, Makarand Sonare wrote:
> Fix VMX preemption timer migration. Add a selftest to ensure post migration
> both L1 and L2 VM observe the VMX preemption timer exit close to the original
> expiration deadline.

For versions > 1, please put a brief blurb in the cover letter (or in the
ignored part of each patch) explaining what changed.  It's also helpful to
give attribution, not so much for the sake of giving credit, but to give
other reviewers context.

Something like:

  v3: Moved timer deadline to kvm_vmx_nested_state_hdr. [Paolo]

  v2: Fixed xyz.

That helps reviewers understand what has changed and what feedback has been
addressed (or to remind them of what feedback they gave :-D), and helps you
avoid getting conflicting feedback.

> Makarand Sonare (1):
>   KVM: selftests: VMX preemption timer migration test
> 
> Peter Shier (1):
>   KVM: nVMX: Fix VMX preemption timer migration
> 
>  Documentation/virt/kvm/api.rst                |   4 +
>  arch/x86/include/uapi/asm/kvm.h               |   3 +
>  arch/x86/kvm/vmx/nested.c                     |  45 +++-
>  arch/x86/kvm/vmx/vmx.h                        |   2 +
>  arch/x86/kvm/x86.c                            |   3 +-
>  include/uapi/linux/kvm.h                      |   1 +
>  tools/arch/x86/include/uapi/asm/kvm.h         |   1 +
>  tools/testing/selftests/kvm/.gitignore        |   1 +
>  tools/testing/selftests/kvm/Makefile          |   1 +
>  .../testing/selftests/kvm/include/kvm_util.h  |   2 +
>  .../selftests/kvm/include/x86_64/processor.h  |  11 +-
>  .../selftests/kvm/include/x86_64/vmx.h        |  27 ++
>  .../kvm/x86_64/vmx_preemption_timer_test.c    | 255 ++++++++++++++++++
>  13 files changed, 344 insertions(+), 12 deletions(-)
>  create mode 100644 tools/testing/selftests/kvm/x86_64/vmx_preemption_timer_test.c
> 
> --
> 2.26.2.761.g0e0b3e54be-goog
> 



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux