On Mon, 18 May 2020 at 16:53, Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> wrote: > > If a address_space_write() fails while calling > set_kernel_args(), the guest kernel will boot > using crap data. Avoid that by aborting if this > ever occurs. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> I think it's reasonable to make these be fatal, but I think we shouldn't just assert() but instead make set_kernel_arg() and set_kernel_args_old() return a success/failure indication, and report failures to the user as fatal errors. thanks -- PMM
