On 06.05.20 20:57, Pankaj Gupta wrote: >> Let's add a proxy for virtio-mem, make it a memory device, and >> pass-through the properties. >> >> Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx> >> Cc: Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx> >> Cc: "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx> >> Cc: Igor Mammedov <imammedo@xxxxxxxxxx> >> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> >> --- >> hw/virtio/Makefile.objs | 1 + >> hw/virtio/virtio-mem-pci.c | 131 +++++++++++++++++++++++++++++++++++++ >> hw/virtio/virtio-mem-pci.h | 33 ++++++++++ >> include/hw/pci/pci.h | 1 + >> 4 files changed, 166 insertions(+) >> create mode 100644 hw/virtio/virtio-mem-pci.c >> create mode 100644 hw/virtio/virtio-mem-pci.h >> >> diff --git a/hw/virtio/Makefile.objs b/hw/virtio/Makefile.objs >> index 7df70e977e..b9661f9c01 100644 >> --- a/hw/virtio/Makefile.objs >> +++ b/hw/virtio/Makefile.objs >> @@ -19,6 +19,7 @@ obj-$(call land,$(CONFIG_VHOST_USER_FS),$(CONFIG_VIRTIO_PCI)) += vhost-user-fs-p >> obj-$(CONFIG_VIRTIO_IOMMU) += virtio-iommu.o >> obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock.o >> obj-$(CONFIG_VIRTIO_MEM) += virtio-mem.o >> +common-obj-$(call land,$(CONFIG_VIRTIO_MEM),$(CONFIG_VIRTIO_PCI)) += virtio-mem-pci.o >> >> ifeq ($(CONFIG_VIRTIO_PCI),y) >> obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock-pci.o >> diff --git a/hw/virtio/virtio-mem-pci.c b/hw/virtio/virtio-mem-pci.c >> new file mode 100644 >> index 0000000000..a47d21c81f >> --- /dev/null >> +++ b/hw/virtio/virtio-mem-pci.c >> @@ -0,0 +1,131 @@ >> +/* >> + * Virtio MEM PCI device >> + * >> + * Copyright (C) 2020 Red Hat, Inc. >> + * >> + * Authors: >> + * David Hildenbrand <david@xxxxxxxxxx> >> + * >> + * This work is licensed under the terms of the GNU GPL, version 2. >> + * See the COPYING file in the top-level directory. >> + */ >> + >> +#include "qemu/osdep.h" >> + > Don't think we need the blank line here. > Right, thanks! [...] >> -- >> 2.25.3 > Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@xxxxxxxxx> > Thanks! -- Thanks, David / dhildenb
