On 14/05/20 09:33, Andrew Jones wrote:
> diff --git a/lib/auxinfo.h b/lib/auxinfo.h
> index 08b96f8ece4c..a46a1e6f6a62 100644
> --- a/lib/auxinfo.h
> +++ b/lib/auxinfo.h
> @@ -13,7 +13,6 @@ struct auxinfo {
> unsigned long flags;
> };
>
> -/* No extern! Define a common symbol. */
> -struct auxinfo auxinfo;
> +extern struct auxinfo auxinfo;
> #endif
> #endif
> diff --git a/x86/Makefile.common b/x86/Makefile.common
> index ab67ca0a9fda..2ea9c9f5bbcc 100644
> --- a/x86/Makefile.common
> +++ b/x86/Makefile.common
> @@ -5,6 +5,7 @@ all: directories test_cases
> cflatobjs += lib/pci.o
> cflatobjs += lib/pci-edu.o
> cflatobjs += lib/alloc.o
> +cflatobjs += lib/auxinfo.o
> cflatobjs += lib/vmalloc.o
> cflatobjs += lib/alloc_page.o
> cflatobjs += lib/alloc_phys.o
>
>
> Thanks,
> drew
>
Yes, this sounds good.
