Re: [PATCH 1/3 v2] KVM: x86: Create mask for guest CR4 reserved bits in kvm_update_cpuid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/3 v2] KVM: x86: Create mask for guest CR4 reserved bits in kvm_update_cpuid()
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Sat, 9 May 2020 14:56:17 +0200
In-reply-to: <20200509003652.25178-2-krish.sadhukhan@oracle.com>
References: <20200509003652.25178-1-krish.sadhukhan@oracle.com> <20200509003652.25178-2-krish.sadhukhan@oracle.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 09/05/20 02:36, Krish Sadhukhan wrote:
> +extern u64 __guest_cr4_reserved_bits;
> +
>  int kvm_update_cpuid(struct kvm_vcpu *vcpu)

This cannot be a global, it is different for each guest since it depends
on their CPUID.  Please put it in vcpu->arch.

Paolo

References:
- [PATCH 0/3 v2] KVM: nSVM: Check MBZ bits in CR3 and CR4 on vmrun of nested guests
  - From: Krish Sadhukhan
- [PATCH 1/3 v2] KVM: x86: Create mask for guest CR4 reserved bits in kvm_update_cpuid()
  - From: Krish Sadhukhan

Prev by Date: Re: [PATCH 2/2] KVM: x86: Print symbolic names of VMX VM-Exit flags in traces
Next by Date: Re: [PATCH kvm-unit-tests] svm: Test V_IRQ injection
Previous by thread: [PATCH 1/3 v2] KVM: x86: Create mask for guest CR4 reserved bits in kvm_update_cpuid()
Next by thread: [PATCH 3/3 v2] KVM: nSVM: Test that MBZ bits in CR3 and CR4 are not set on vmrun of nested guests
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]

Powered by Linux