Hi, Alex, On Tue, May 05, 2020 at 03:54:53PM -0600, Alex Williamson wrote: > +/* > + * Zap mmaps on open so that we can fault them in on access and therefore > + * our vma_list only tracks mappings accessed since last zap. > + */ > +static void vfio_pci_mmap_open(struct vm_area_struct *vma) > +{ > + zap_vma_ptes(vma, vma->vm_start, vma->vm_end - vma->vm_start); A pure question: is this only a safety-belt or it is required in some known scenarios? In all cases: Reviewed-by: Peter Xu <peterx@xxxxxxxxxx> Thanks, -- Peter Xu