On Tue, Aug 18, 2009 at 10:20:11PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > > On Thu, Aug 13, 2009 at 04:35:01PM -0400, Masami Hiramatsu wrote: > >> Use TRACE_FIELD_ZERO(type, item) instead of TRACE_FIELD_ZERO_CHAR(item). > >> This also includes a fix of TRACE_ZERO_CHAR() macro. > > > > > > I can't find what the fix is about (see below) > > Ah, OK. This patch actually includes two parts. > > One is introducing TRACE_FIELD_ZERO which is more generic than > TRACE_FIELD_ZERO_CHAR, I think. > > Another is a typo fix of TRACE_ZERO_CHAR. Ok. > >> > >> +#undef TRACE_FIELD_ZERO > >> +#define TRACE_FIELD_ZERO(type, item) > >> + > > > > > > > > Is it about the above moving? > > If so, could you just tell so that I can add something about > > it in the changelog. > > No, I assume that TRACE_ZERO_CHAR is just a typo of TRACE_FIELD_ZERO_CHAR. > (because I couldn't find any other TRACE_ZERO_CHAR) > > BTW, this patch may not be needed after applying patch 10/12, since > it removes ftrace event definitions of TRACE_KPROBE/KRETPROBE. > > Perhaps, would I better merge and split those additional patches(and > remove this change)? > (It also could make the incremental review hard...) > > Thank you, > No let's keep it as is. It should be fine. Thanks. > -- > Masami Hiramatsu > > Software Engineer > Hitachi Computer Products (America), Inc. > Software Solutions Division > > e-mail: mhiramat@xxxxxxxxxx > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
