On 4/23/20 3:50 PM, Sean Christopherson wrote:
> Make test_ioapic_physical_destination_mode() depending on having at
> least two CPUs as it sets ->dest_id to '1', i.e. expects CPU0 and CPU1
> to exist. This analysis is backed up by the fact that the test was
> originally gated by cpu_count() > 1.
>
> Fixes: dcf27dc5b5499 ("x86: Fix the logical destination mode test")
> Cc: Nitesh Narayan Lal <nitesh@xxxxxxxxxx>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> ---
> x86/ioapic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/x86/ioapic.c b/x86/ioapic.c
> index 3106531..f315e4b 100644
> --- a/x86/ioapic.c
> +++ b/x86/ioapic.c
> @@ -504,7 +504,8 @@ int main(void)
> test_ioapic_level_tmr(true);
> test_ioapic_edge_tmr(true);
>
> - test_ioapic_physical_destination_mode();
> + if (cpu_count() > 1)
> + test_ioapic_physical_destination_mode();
> if (cpu_count() > 3)
> test_ioapic_logical_destination_mode();
>
Thank you Sean for fixing this.
--
Nitesh
Attachment:
signature.asc
Description: OpenPGP digital signature
