On 22/04/20 23:36, Jim Mattson wrote: >>> + case KVM_CAP_HALT_POLL: { >>> + if (cap->flags || cap->args[0] != (unsigned int)cap->args[0]) >>> + return -EINVAL; >>> + >>> + kvm->max_halt_poll_ns = cap->args[0]; >> Is it safe to allow any value from userspace here or would it maybe make >> sense to only allow [0, global halt_poll_ns]? > Would that restriction help to get this change accepted? > No, in the sense that I'm applying it already. Paolo