Re: [kvm-unit-tests PATCH v5 02/10] s390x: Use PSW bits definitions in cstart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22.04.20 10:59, Pierre Morel wrote:
> 
> 
> On 2020-04-22 09:44, David Hildenbrand wrote:
>>
>>>> diff --git a/s390x/cstart64.S b/s390x/cstart64.S
>>>> index 45da523..2885a36 100644
>>>> --- a/s390x/cstart64.S
>>>> +++ b/s390x/cstart64.S
>>>> @@ -12,6 +12,7 @@
>>>>    */
>>>>   #include <asm/asm-offsets.h>
>>>>   #include <asm/sigp.h>
>>>> +#include <asm/arch_def.h>
>>>>   
>>>>   .section .init
>>>>   
>>>> @@ -214,19 +215,19 @@ svc_int:
>>>>   
>>>>   	.align	8
>>>>   reset_psw:
>>>> -	.quad	0x0008000180000000
>>>> +	.quad	PSW_EXCEPTION_MASK
>>>
>>> That won't work, this is a short PSW and you're removing the short
>>> indication here. Notice the 0008 at the front.
> 
> hum... :(
> 
>>
>> Good catch! Guess it would have bailed out when testing.
>>
>>
> 
> Yes it does. Sorry.

No worries, I run everything through the machinery before picking
patches up.

Feel free to resend only the 4/5 patches you want to have in first.

-- 
Thanks,

David / dhildenb




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux