On Tue, Apr 21, 2020 at 01:16:42PM +0200, Paolo Bonzini wrote: > On 21/04/20 11:29, Wei Liu wrote: > > On Mon, Apr 20, 2020 at 10:38:35AM -0700, Michael Kelley wrote: > >> The Hyper-V Reference TSC Page structure is defined twice. struct > >> ms_hyperv_tsc_page has padding out to a full 4 Kbyte page size. But > >> the padding is not needed because the declaration includes a union > >> with HV_HYP_PAGE_SIZE. KVM uses the second definition, which is > >> struct _HV_REFERENCE_TSC_PAGE, because it does not have the padding. > >> > >> Fix the duplication by removing the padding from ms_hyperv_tsc_page. > >> Fix up the KVM code to use it. Remove the no longer used struct > >> _HV_REFERENCE_TSC_PAGE. > >> > >> There is no functional change. > >> > >> Signed-off-by: Michael Kelley <mikelley@xxxxxxxxxxxxx> > >> --- > >> arch/x86/include/asm/hyperv-tlfs.h | 8 -------- > >> arch/x86/include/asm/kvm_host.h | 2 +- > >> arch/x86/kvm/hyperv.c | 4 ++-- > > > > Paolo, this patch touches KVM code. Let me know how you would like to > > handle this. > > Just include it, I don't expect conflicts. > > Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> Ack.