On 16/04/20 17:59, Peter Xu wrote: > We always do synchronous fault in for those pages. > > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx> > --- > > Or, does it make sense to allow async pf for PFNMAP|IO too? I just > didn't figure out why not... > --- I think async pf would use FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_RETRY_NOWAIT. On failure you would set *async = true. In practice I don't think fixup_user_fault is likely to do anything asynchronously. Paolo