Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait

[Davidlohr Bueso <dave@xxxxxxxxxxxx>]

On Wed, 25 Mar 2020, Paolo Bonzini wrote:

> On 24/03/20 05:44, Davidlohr Bueso wrote:
> > diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c
> > index 71244bf87c3a..e049fcb3dffb 100644
> > --- a/arch/mips/kvm/mips.c
> > +++ b/arch/mips/kvm/mips.c
> > @@ -290,8 +290,7 @@ static enum hrtimer_restart kvm_mips_comparecount_wakeup(struct hrtimer *timer)
> > 	kvm_mips_callbacks->queue_timer_int(vcpu);
> >
> > 	vcpu->arch.wait = 0;
> > -	if (swq_has_sleeper(&vcpu->wq))
> > -		swake_up_one(&vcpu->wq);
> > +	rcuwait_wake_up(&vcpu->wait)
>
> This is missing a semicolon.  (KVM MIPS is known not to compile and will
> be changed to "depends on BROKEN" in 5.7).

Do you want me to send another version with this fix or do you prefer
fixing it when/if picked up?

Thanks,
Davidlohr