Re: [kvm-unit-tests RESEND PATCH] x86: gtests: add new test for vmread/vmwrite flags preservation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 13, 2020 at 4:52 PM Jim Mattson <jmattson@xxxxxxxxxx> wrote:
>
> On Mon, Apr 13, 2020 at 4:50 PM Sean Christopherson
> <sean.j.christopherson@xxxxxxxxx> wrote:
> >
> > s/gtest/nVMX for the shortlog.  I thought this was somehow related to the
> > Google Test framework, especially coming from a @google.com address.
> >
> > On Mon, Apr 13, 2020 at 10:24:32AM -0700, Simon Smith wrote:
> > > This commit adds new unit tests for commit a4d956b93904 ("KVM: nVMX:
> > > vmread should not set rflags to specify success in case of #PF")
> > >
> > > The two new tests force a vmread and a vmwrite on an unmapped
> > > address to cause a #PF and verify that the low byte of %rflags is
> > > preserved and that %rip is not advanced.  The cherry-pick fixed a
> > > bug in vmread, but we include a test for vmwrite as well for
> > > completeness.
> >
> > I think some of Google's process is bleeding into kvm-unit-tests, I'm pretty
> > sure the aforementioned commit wasn't cherry-picked into Paolo's tree.  :-D
>
> I see it in Linus' tree.

Oh, I see what you mean. s/cherry-pick/commit/.

> > > Before the aforementioned commit, the ALU flags would be incorrectly
> > > cleared and %rip would be advanced (for vmread).



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux