On Mon, Apr 06, 2020 at 02:10:53PM -0300, Wainer dos Santos Moschetta wrote: > > On 4/4/20 4:32 AM, Andrew Jones wrote: > > On Fri, Apr 03, 2020 at 02:24:28PM -0300, Wainer dos Santos Moschetta wrote: > > > This patch introduces the mem_slot_test test which checks > > > an VM can have added memory slots up to the limit defined in > > > KVM_CAP_NR_MEMSLOTS. Then attempt to add one more slot to > > > verify it fails as expected. > > > > > > Signed-off-by: Wainer dos Santos Moschetta <wainersm@xxxxxxxxxx> > > > --- > > > tools/testing/selftests/kvm/.gitignore | 1 + > > > tools/testing/selftests/kvm/Makefile | 3 + > > > tools/testing/selftests/kvm/mem_slot_test.c | 85 +++++++++++++++++++++ > > > 3 files changed, 89 insertions(+) > > > create mode 100644 tools/testing/selftests/kvm/mem_slot_test.c > > > > > > diff --git a/tools/testing/selftests/kvm/.gitignore b/tools/testing/selftests/kvm/.gitignore > > > index 16877c3daabf..232f24d6931a 100644 > > > --- a/tools/testing/selftests/kvm/.gitignore > > > +++ b/tools/testing/selftests/kvm/.gitignore > > > @@ -22,3 +22,4 @@ > > > /dirty_log_test > > > /kvm_create_max_vcpus > > > /steal_time > > > +/mem_slot_test > > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > > > index 712a2ddd2a27..69b44178f48b 100644 > > > --- a/tools/testing/selftests/kvm/Makefile > > > +++ b/tools/testing/selftests/kvm/Makefile > > > @@ -33,12 +33,14 @@ TEST_GEN_PROGS_x86_64 += demand_paging_test > > > TEST_GEN_PROGS_x86_64 += dirty_log_test > > > TEST_GEN_PROGS_x86_64 += kvm_create_max_vcpus > > > TEST_GEN_PROGS_x86_64 += steal_time > > > +TEST_GEN_PROGS_x86_64 += mem_slot_test > > > TEST_GEN_PROGS_aarch64 += clear_dirty_log_test > > > TEST_GEN_PROGS_aarch64 += demand_paging_test > > > TEST_GEN_PROGS_aarch64 += dirty_log_test > > > TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus > > > TEST_GEN_PROGS_aarch64 += steal_time > > > +TEST_GEN_PROGS_aarch64 += mem_slot_test > > kvm selftests has a bad case of OCD when it comes to lists of tests. In > > the .gitignore and the Makefile we keep our tests in alphabetical order. > > Maybe we should stop, because it's a bit annoying to maintain, but my > > personal OCD won't allow it to be on my watch. Please fix the above > > three lists. > > I will fix it on v3. > > Kind of related... has ever been discussed a naming convention for kvm > selftests? It would allow the use of regex on both .gitignore and > Makefile...and bye-bye those sorted lists. It's never been discussed that I know of. Feel free to send an RFC if you'd like to kick off the discussion :-) Thanks, drew
