On 02.04.20 18:19, Cornelia Huck wrote:
> On Thu, 2 Apr 2020 11:44:41 -0400
> Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote:
>
>> Two minimal tests:
>> - our own CPU should be running when we check ourselves
>> - a CPU should at least have some times with a not running
>> indication. To speed things up we stop CPU1
>>
>> Also rename smp_cpu_running to smp_sense_running_status.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
>> ---
>> lib/s390x/smp.c | 2 +-
>> lib/s390x/smp.h | 2 +-
>> s390x/smp.c | 15 +++++++++++++++
>> 3 files changed, 17 insertions(+), 2 deletions(-)
>>
>
> (...)
>
>> diff --git a/s390x/smp.c b/s390x/smp.c
>> index 79cdc1f..4450aff 100644
>> --- a/s390x/smp.c
>> +++ b/s390x/smp.c
>> @@ -210,6 +210,20 @@ static void test_emcall(void)
>> report_prefix_pop();
>> }
>>
>> +static void test_sense_running(void)
>> +{
>> + report_prefix_push("sense_running");
>> + /* we are running */
>
> Maybe /* we (CPU0) are running */ ?
I fixed that one up
>
>> + report(smp_sense_running_status(0), "CPU0 sense claims running");
>> + /* make sure CPU is stopped to speed up the not running case */
>
> "the target CPU" ?
I'm using
"stop the target CPU (CPU1) to speed up the not running case"
to make it fit into a single line :)
(Christian, correct me if you disagree with these changes)
--
Thanks,
David / dhildenb
