On 3/26/2020 12:12 AM, shuah wrote:
On 3/25/20 8:01 AM, Xiaoyao Li wrote:
I attempted to build KVM selftests on a specified dir, unfortunately
neither "make O=/path/to/mydir TARGETS=kvm" in
tools/testing/selftests, nor
"make OUTPUT=/path/to/mydir" in tools/testing/selftests/kvm work.
Please elaborate on the problems you are seeing. I would like you
to describe in detail the problems you are seeing and how you are
fixing them in this patch series.
The problem you are fixing here is subdir structure not being
supported for relocatable builds and the Makefile not being
able to locate headers files. These are issues, however, these
need to be fixed in the kvm Makefile
Maybe I should have sent it as RFC.
OK, then I'll just resend patch 1 in v1 to fix the subdir not created
issue for relocatable build, in kvm Makefile. Obviously lib.mk doesn't
create it, and you don't allow me to touch lib.mk
About headers issue, since I'm not familiar with Makefile, I don't want
to waste any more time on it and I decide to drop them.
I can add a "make mrproper" in my script to do the cleanup as a workaround.
And never make kvm selftests in parent dir with
make O=/somewhere TARGETS=kvm
to workaround the header not found issue.
Please look at arm64, android, futex tests as examples. lib.mk
and main selftests Makefile allow for overrides for make targets.
When a test has sub-dir structure and libraries, it is easier to
handle these in the individual Makefile.
Please fix the problems you are seeing in kvm Makefile.
>I only test the sub TARGET of kvm.
>In theory, it won't break other TARGET of selftests.
When you change lib.mk which is a common infrastructure, theory
doesn't help. Statements like this make me very reluctant to
accept patches. :)
This is one reason why I asked Paolo to drop these patches.
thanks,
-- Shuah
