Stephane Bakhos wrote:
Stephane Bakhos wrote:
This is my first patch, so I apoligize for breaking any convention.
This patch modifies the order used in net.c for tap initialization.
It runs the script before the device is opened.
This will break existing scripts that do not rely on explicitly
setting ifname= and instead rely on tap_open() to allocate a tap
device. In fact, this is one of the most common usages.
What about adding create and destroy scripts that are executed before
tap_open / tap_close?
Right now, the scripts serve an important purpose. The run after we
allocate a tap device but before the guest runs. They serve as a hook
in a very specific place in time.
The semantics you describe are basically, run a script some time before
we open the tap device. Well, that's effectively equivalent to just
running the script before running QEMU. So I don't really see any
compelling reason to introduce such a hook in QEMU today since you can
already achieve this functionality.
Regards,
Anthony Liguori
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
