On 23/03/20 17:24, Sean Christopherson wrote: >> We don't seem to use the return value a lot, actually, >> inject_emulated_exception() seems to be the only one, the rest just call >> it without checking the return value. Judging by the new name, I'd guess >> that the function returns whether it was able to inject the exception or >> not but this doesn't seem to be the case. My suggestion would then be to >> make it return 'void' and return 'fault->nested_page_fault' separately >> in inject_emulated_exception(). > Oooh, I like that idea. The return from the common helper also confuses me > every time I look at it. > Separate patch, please. I'm not sure it makes a great difference though. Paolo
