Re: [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/03/20 15:29, Christian Borntraeger wrote:
> 
> 
> On 28.02.20 10:34, Paolo Bonzini wrote:
>> On 28/02/20 09:49, Christian Borntraeger wrote:
>>> Sparse notices that declaration and implementation do not match:
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: warning: incorrect type in return expression (different address spaces)
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17:    expected struct kvm_vcpu [noderef] <asn:3> **
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17:    got struct kvm_vcpu *[noderef] <asn:3> *
>>>
>>> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
>>> ---
>>>  include/linux/kvm_host.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
>>> index 7944ad6ac10b..bcb9b2ac0791 100644
>>> --- a/include/linux/kvm_host.h
>>> +++ b/include/linux/kvm_host.h
>>> @@ -1344,7 +1344,7 @@ static inline void kvm_vcpu_set_dy_eligible(struct kvm_vcpu *vcpu, bool val)
>>>  #endif /* CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT */
>>>  
>>>  struct kvm_vcpu *kvm_get_running_vcpu(void);
>>> -struct kvm_vcpu __percpu **kvm_get_running_vcpus(void);
>>> +struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void);
>>>  
>>>  #ifdef CONFIG_HAVE_KVM_IRQ_BYPASS
>>>  bool kvm_arch_has_irq_bypass(void);
>>>
>>
>> Queued, thanks.
> 
> Ping. I cant find this in kvm/next.
> 

It's in 5.6-rc4.

Paolo




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux