On 18/03/20 18:02, Sean Christopherson wrote: > So something like this? > > if (!nested_ept) > kvm_mmu_new_cr3(vcpu, cr3, enable_ept || > nested_cpu_has_vpid(vmcs12)); ... which is exactly nested_has_guest_tlb_tag(vcpu). Well, not exactly but it's a bug in your code above. :) It completely makes sense to use that as the third argument, and while a comment is still needed it will be much smaller. Paolo
