Re: [PATCH v2] KVM: s390: Also reset registers in sync regs for initial cpu reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 10 Mar 2020 14:21:23 +0100
David Hildenbrand <david@xxxxxxxxxx> wrote:

> On 10.03.20 14:12, Christian Borntraeger wrote:
> > When we do the initial CPU reset we must not only clear the registers
> > in the internal data structures but also in kvm_run sync_regs. For
> > modern userspace sync_regs is the only place that it looks at.
> > 
> > Cc: stable@xxxxxxxxxxxxxxx  
> 
> # v?
> 
> > Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> > ---
> >  arch/s390/kvm/kvm-s390.c | 18 +++++++++++++++++-
> >  1 file changed, 17 insertions(+), 1 deletion(-)

> However, I do wonder if that ioctl *originally* was designed for that -
> IOW if this is rally a stable patch or just some change that makes
> sense. IIRC, userspace/QEMU always did the right thing, no? There was no
> documentation about the guarantees AFAIK.

The documentation only refers to the PoP for what is actually reset...
should it also mention the sync regs?




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux