On Mon, Mar 09, 2020 at 11:24:17AM +0100, Eric Auger wrote: ... > diff --git a/lib/arm/asm/gic-v3-its.h b/lib/arm/asm/gic-v3-its.h > index 0096de6..956d7b8 100644 > --- a/lib/arm/asm/gic-v3-its.h > +++ b/lib/arm/asm/gic-v3-its.h > @@ -5,9 +5,8 @@ > * > * This work is licensed under the terms of the GNU LGPL, version 2. > */ > - > -#ifndef _ASMARM_GICv3_ITS > -#define _ASMARM_GICv3_ITS > +#ifndef _ASMARM_GIC_V3_ITS_H_ > +#define _ASMARM_GIC_V3_ITS_H_ Another fix to squash into the patch where the lines are introduced. > > /* dummy its_data struct to allow gic_get_dt_bases() call */ > struct its_data { > @@ -19,5 +18,9 @@ static inline void test_its_introspection(void) > { > report_abort("not supported on 32-bit"); > } > +static inline void test_its_trigger(void) > +{ > + report_abort("not supported on 32-bit"); As mentioned before, we don't want test_* and report_* functions in the library code. > +} > > #endif /* _ASMARM_GICv3_ITS */ Forgot to change _ASMARM_GICv3_ITS here. > -- > 2.20.1 > Thanks, drew