On Wed, Aug 12, 2009 at 12:06:59PM +0300, Avi Kivity wrote: > On 08/12/2009 11:42 AM, Gleb Natapov wrote: >> >> >>> What's this? >>> >>> >> If there is not GSI mapping use pin as gsi. This what current code does. >> We can BUG() here I think. >> >> > > We can't BUG() userspace can change the mapping before the ack is received. > Yes. Malicious userspace can remove GSI mapping for GSI with ack notifier registered, so we can't BUG(). But making GSI=pin doesn't look correct too. Should we just skip calling ack notifier? -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html