The CPUID features PDCM, DS and DTES64 are required for PEBS feature. This patch expose CPUID feature PDCM, DS and DTES64 to guest when PEBS is supported in KVM. Originally-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> Signed-off-by: Luwei Kang <luwei.kang@xxxxxxxxx> Co-developed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx> Signed-off-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx> --- arch/x86/include/asm/kvm_host.h | 2 ++ arch/x86/kvm/cpuid.c | 9 ++++++--- arch/x86/kvm/svm.c | 12 ++++++++++++ arch/x86/kvm/vmx/capabilities.h | 17 +++++++++++++++++ arch/x86/kvm/vmx/vmx.c | 2 ++ 5 files changed, 39 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 83abb49..033d9f9 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1180,6 +1180,8 @@ struct kvm_x86_ops { bool (*umip_emulated)(void); bool (*pt_supported)(void); bool (*pku_supported)(void); + bool (*pdcm_supported)(void); + bool (*dtes64_supported)(void); int (*check_nested_events)(struct kvm_vcpu *vcpu, bool external_intr); void (*request_immediate_exit)(struct kvm_vcpu *vcpu); diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index b1c4694..92dabf3 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -446,6 +446,9 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function, unsigned f_rdtscp = kvm_x86_ops->rdtscp_supported() ? F(RDTSCP) : 0; unsigned f_xsaves = kvm_x86_ops->xsaves_supported() ? F(XSAVES) : 0; unsigned f_intel_pt = kvm_x86_ops->pt_supported() ? F(INTEL_PT) : 0; + unsigned int f_pdcm = kvm_x86_ops->pdcm_supported() ? F(PDCM) : 0; + unsigned int f_ds = kvm_x86_ops->dtes64_supported() ? F(DS) : 0; + unsigned int f_dtes64 = kvm_x86_ops->dtes64_supported() ? F(DTES64) : 0; /* cpuid 1.edx */ const u32 kvm_cpuid_1_edx_x86_features = @@ -454,7 +457,7 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function, F(CX8) | F(APIC) | 0 /* Reserved */ | F(SEP) | F(MTRR) | F(PGE) | F(MCA) | F(CMOV) | F(PAT) | F(PSE36) | 0 /* PSN */ | F(CLFLUSH) | - 0 /* Reserved, DS, ACPI */ | F(MMX) | + 0 /* Reserved */ | f_ds | 0 /* ACPI */ | F(MMX) | F(FXSR) | F(XMM) | F(XMM2) | F(SELFSNOOP) | 0 /* HTT, TM, Reserved, PBE */; /* cpuid 0x80000001.edx */ @@ -471,10 +474,10 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function, const u32 kvm_cpuid_1_ecx_x86_features = /* NOTE: MONITOR (and MWAIT) are emulated as NOP, * but *not* advertised to guests via CPUID ! */ - F(XMM3) | F(PCLMULQDQ) | 0 /* DTES64, MONITOR */ | + F(XMM3) | F(PCLMULQDQ) | f_dtes64 | 0 /* MONITOR */ | 0 /* DS-CPL, VMX, SMX, EST */ | 0 /* TM2 */ | F(SSSE3) | 0 /* CNXT-ID */ | 0 /* Reserved */ | - F(FMA) | F(CX16) | 0 /* xTPR Update, PDCM */ | + F(FMA) | F(CX16) | 0 /* xTPR Update */ | f_pdcm | F(PCID) | 0 /* Reserved, DCA */ | F(XMM4_1) | F(XMM4_2) | F(X2APIC) | F(MOVBE) | F(POPCNT) | 0 /* Reserved*/ | F(AES) | F(XSAVE) | 0 /* OSXSAVE */ | F(AVX) | diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 24c0b2b..984ab6c 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -6123,6 +6123,16 @@ static bool svm_pku_supported(void) return false; } +static bool svm_pdcm_supported(void) +{ + return false; +} + +static bool svm_dtes64_supported(void) +{ + return false; +} + #define PRE_EX(exit) { .exit_code = (exit), \ .stage = X86_ICPT_PRE_EXCEPT, } #define POST_EX(exit) { .exit_code = (exit), \ @@ -7485,6 +7495,8 @@ static void svm_pre_update_apicv_exec_ctrl(struct kvm *kvm, bool activate) .umip_emulated = svm_umip_emulated, .pt_supported = svm_pt_supported, .pku_supported = svm_pku_supported, + .pdcm_supported = svm_pdcm_supported, + .dtes64_supported = svm_dtes64_supported, .set_supported_cpuid = svm_set_supported_cpuid, diff --git a/arch/x86/kvm/vmx/capabilities.h b/arch/x86/kvm/vmx/capabilities.h index f486e26..9e352b5 100644 --- a/arch/x86/kvm/vmx/capabilities.h +++ b/arch/x86/kvm/vmx/capabilities.h @@ -5,6 +5,7 @@ #include <asm/vmx.h> #include "lapic.h" +#include "pmu.h" extern bool __read_mostly enable_vpid; extern bool __read_mostly flexpriority_enabled; @@ -151,6 +152,22 @@ static inline bool vmx_pku_supported(void) return boot_cpu_has(X86_FEATURE_PKU); } +static inline bool vmx_pdcm_supported(void) +{ + if (kvm_x86_ops->pmu_ops->is_pebs_via_ds_supported) + return kvm_x86_ops->pmu_ops->is_pebs_via_ds_supported(); + + return false; +} + +static inline bool vmx_dtes64_supported(void) +{ + if (kvm_x86_ops->pmu_ops->is_pebs_via_ds_supported) + return kvm_x86_ops->pmu_ops->is_pebs_via_ds_supported(); + + return false; +} + static inline bool cpu_has_vmx_rdtscp(void) { return vmcs_config.cpu_based_2nd_exec_ctrl & diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 40b1e61..cef7089 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -7951,6 +7951,8 @@ static bool vmx_check_apicv_inhibit_reasons(ulong bit) .umip_emulated = vmx_umip_emulated, .pt_supported = vmx_pt_supported, .pku_supported = vmx_pku_supported, + .pdcm_supported = vmx_pdcm_supported, + .dtes64_supported = vmx_dtes64_supported, .request_immediate_exit = vmx_request_immediate_exit, -- 1.8.3.1