Re: [PATCH v2 66/66] KVM: x86: Move nSVM CPUID 0x8000000A handing into common x86 code

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On 03/03/20 00:57, Sean Christopherson wrote:
> +	case 0x8000000A:
> +		if (!kvm_cpu_cap_has(X86_FEATURE_SVM)) {
> +			entry->eax = entry->ebx = entry->ecx = entry->edx = 0;
> +			break;
> +		}
> +		entry->eax = 1; /* SVM revision 1 */
> +		entry->ebx = 8; /* Lets support 8 ASIDs in case we add proper
> +				   ASID emulation to nested SVM */
> +		entry->ecx = 0; /* Reserved */
> +		/* Note, 0x8000000A.EDX is managed via kvm_cpu_caps. */;

... meaning this should do

                cpuid_entry_override(entry, CPUID_8000_000A_EDX);

shouldn't it?

Paolo

> +		break;