On Fri, Feb 28, 2020 at 10:24 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On 28/02/20 19:19, Oliver Upton wrote: > > If we wanted to be absolutely certain that the extern labels used for > > assertions about the guest RIP are correct, we may still want it. > > Alternatively, I could rewrite the test such that the guest will > > report the instruction boundary where it anticipates MTF whenever it > > makes the vmcall to request the host turns on MTF. > > Right, but it's used only once, and as a function pointer at that, so > there's only so much that the compiler can do to "optimize". Let's > think about how to fix it if it breaks. > > Paolo > Very true. Unchecked paranoia of the compiler isn't warranted here. Thanks :) -- Best, Oliver
