On 27/02/20 04:33, Michael Ellerman wrote: > We've had -Werror enabled by default on powerpc for over 10 years, and > haven't had many complaints. Possibly that's just because no one builds > powerpc kernels ... I looked for other cases of -Werror being always on in Linux before writing this patch. There are both unconditional cases and others like PPC where it's governed by Kconfig. I will add a Kconfig for now. It probably should be made global instead of having a dozen different Kconfig symbols. kvm_timer_init should be fixed, though. Paolo > The key thing is that it's configurable, so if it does break the build > for someone they can just turn it off. It's also off by default for > allyes/allmod builds because the user-selectable option disables > -Werror, eg: