From: Paolo Bonzini <pbonzini@xxxxxxxxxx> These were already fixed by KVM_CAP_EXCEPTION_PAYLOAD, but they were failing on old QEMUs that did not support it. The recent KVM patch "KVM: x86: Deliver exception payload on KVM_GET_VCPU_EVENTS" however fixed them even there, so it is about time to flip the arguments to check_db_exit and avoid ugly XPASS results with newer versions of QEMU. Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> Signed-off-by: Bill Wendling <morbo@xxxxxxxxxx> --- x86/vmx_tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c index b31c360..1323dc5 100644 --- a/x86/vmx_tests.c +++ b/x86/vmx_tests.c @@ -8332,7 +8332,7 @@ static void vmx_db_test(void) * modified DR6, but fails miserably. */ single_step_guest("Software synthesized single-step", starting_dr6, 0); - check_db_exit(true, true, false, &post_wbinvd, DR_STEP, starting_dr6); + check_db_exit(false, false, false, &post_wbinvd, DR_STEP, starting_dr6); /* * L0 synthesized #DB trap for single-step in MOVSS shadow is @@ -8342,7 +8342,7 @@ static void vmx_db_test(void) */ single_step_guest("Software synthesized single-step in MOVSS shadow", starting_dr6, BIT(12) | DR_STEP | DR_TRAP0); - check_db_exit(true, true, true, &post_movss_wbinvd, DR_STEP | DR_TRAP0, + check_db_exit(true, false, true, &post_movss_wbinvd, DR_STEP | DR_TRAP0, starting_dr6); /* -- 2.25.0.265.gbab2e86ba0-goog